Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carrying - Handle simultaneously carry action #99

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

Kexanone
Copy link
Member

@Kexanone Kexanone commented Aug 29, 2024

When merged this pull request will:

Background:

  • The previous approach determined whether someone is carrier or carried based on whether the helper compartment is part of the entity's hierarchy. However, this approach leads to race conditions, since it takes several frames for the carried player to move into the helper compartment and become a child of it.

@Kexanone Kexanone added the kind/bug Release Notes: **FIXED:** label Aug 29, 2024
@Kexanone Kexanone added this to the 1.2.0 milestone Aug 29, 2024
@Kexanone Kexanone changed the title Carrying: Handle simultaneously carry action Carrying - Handle simultaneously carry action Sep 6, 2024
@veteran29 veteran29 self-requested a review September 12, 2024 20:23
Copy link
Member

@veteran29 veteran29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kexanone Kexanone merged commit 7c0ca17 into master Sep 23, 2024
@Kexanone Kexanone deleted the carrying/handle-concurrent-carry-action branch September 23, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carrying - Breaks when two players try to initiate carrying simultaneously
2 participants